DokuWiki

It's better when it's simple

User Tools

Site Tools


devel:github

Differences

This shows you the differences between two versions of the page.

Link to this comparison view

devel:github [2012-07-08 19:43]
2001:6f8:1c1a:0:922b:34ff:fe18:7138 created
devel:github [2013-09-12 01:12] (current)
Matt2 Fix capitalization for Git and GitHub.
Line 1: Line 1:
-====== Working with Github ​Pull Requests ======+====== Working with GitHub ​Pull Requests ======
  
-Github ​Pull Requests are the preferred way of sending patches for DokuWiki to the core development team. While individual [[git]] patches may get into the core, a pull request makes it much easier to review the code collaboratively and discuss it before applying it to the code base.+GitHub ​Pull Requests are the preferred way of sending patches for DokuWiki to the core development team. While individual [[Git]] patches may get into the core, a pull request makes it much easier to review the code collaboratively and discuss it before applying it to the code base.
  
-A detailed description on how pull requests work, is available at [[https://​help.github.com/​articles/​using-pull-requests|Github ​Help Section]].+A detailed description on how pull requests work, is available at [[https://​help.github.com/​articles/​using-pull-requests|GitHub ​Help Section]].
  
 When sending pull requests, please keep the following in mind: When sending pull requests, please keep the following in mind:
  
   * Add a comment to your pull request, explaining what your code does and why you think it should be added to DokuWiki (eg. explain actual use cases)   * Add a comment to your pull request, explaining what your code does and why you think it should be added to DokuWiki (eg. explain actual use cases)
-  * Do not mix different features into a single pull request. Pull requests are based on branches, so create different feature ​branches ​in your fork first. Then send pull requests from there.+  * Do not mix different features into a single pull request. Pull requests are based on branches, so create different feature ​branch ​in your fork first. Then send pull requests from there.
  
 We try to give feedback as soon as possible, but especially for very complex topics it might take a while until one of us can have a look at it in detail. Please don't let this discourage you, we love pull requests :-) We try to give feedback as soon as possible, but especially for very complex topics it might take a while until one of us can have a look at it in detail. Please don't let this discourage you, we love pull requests :-)
devel/github.1341769409.txt.gz ยท Last modified: 2012-07-08 19:43 by 2001:6f8:1c1a:0:922b:34ff:fe18:7138