DokuWiki

It's better when it's simple

User Tools

Site Tools


devel:coredevs

Differences

This shows you the differences between two versions of the page.

Link to this comparison view

Next revision
Previous revision
devel:coredevs [2015-05-23 17:35]
andi created
devel:coredevs [2015-05-29 12:34]
andi
Line 5: Line 5:
 ===== How to become a Core Developer ===== ===== How to become a Core Developer =====
  
-You should have joined the main [[:mailinglist|Mailing List]] and have committed successful non-trivial pull requests before.+You should have joined the main [[:mailinglist|Mailing List]] and have successfully committed non-trivial pull requests before.
  
-FIXME+Existing core devs should keep an eye on new contributors and talk to [[user>Andi]] (directly, IRC or Mailing List) when they think someone should get commit permissions.
  
-  * how do we pick new devs? should they apply? do we nominate? do we vote? 
  
 ===== How to be a Core Developer ===== ===== How to be a Core Developer =====
Line 19: Line 18:
   * merge Pull Requests   * merge Pull Requests
  
-Core developers are expected to use their powers responsible and careful. You can merge small PRs (like typos, one-line fixes, translations) right away.+Core developers are expected to use their powers responsibly and carefully. You can merge small PRs (like typos, one-line fixes, translations) right away.
  
-Other PRs should be reviewed by at least two core developers (mark PRs you think are ready to merge with a '':+1:'' comment). You should never merge your own PRs before someone else reviewed them+Other PRs should be reviewed by at least two core developers (mark PRs you think are ready to merge with a '':+1:'' comment). You should never merge your own PRs before someone else reviewed them (unless they are trivial as described above).
- +
-PRs should adhere to our [[devel:coding_style|Coding Style]] and should contain [[devel:unittesting|Unit Tests]] if reasonable, before they are merged. Always make sure Unit Tests ran through befor merging (Travis will check that automatically).+
  
 +PRs should adhere to our [[devel:coding_style|Coding Style]] and should contain [[devel:unittesting|Unit Tests]], if reasonable, before they are merged. Always make sure Unit Tests successfully ran through before merging (Travis will check that automatically).
  
 +You are free to create new branches within the main repository. No need to fork into your own account.
devel/coredevs.txt · Last modified: 2015-05-29 12:34 by andi